[DOCS] Fix trivup example, now requires version flag, update Kafka example test version to current #5027
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the syntax for the trivup module has changed since the README was written, and it now requires a '--version' flag to specify the version.
Also, the example version was very old, so I updated the (example) to a currently supported for (3.9.0). In testing, the tests that pass correctly under 2.3.0 for me also pass under 3.9.0, so I wouldn't expect this to cause any problems, but users are still fine to specify the old version(s) if necessary.
I also added a warning about Python versions (eg. when trying this example with 3.6.9, it fails with the example error provided - it looks like from the release notes, the importlib feature which trivup relies on was introduced in Python 3.7, and I verified by testing several Python versions).