Skip to content

[DOCS] Fix trivup example, now requires version flag, update Kafka example test version to current #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mdb-ebeebe
Copy link

It looks like the syntax for the trivup module has changed since the README was written, and it now requires a '--version' flag to specify the version.

Also, the example version was very old, so I updated the (example) to a currently supported for (3.9.0). In testing, the tests that pass correctly under 2.3.0 for me also pass under 3.9.0, so I wouldn't expect this to cause any problems, but users are still fine to specify the old version(s) if necessary.

I also added a warning about Python versions (eg. when trying this example with 3.6.9, it fails with the example error provided - it looks like from the release notes, the importlib feature which trivup relies on was introduced in Python 3.7, and I verified by testing several Python versions).

@mdb-ebeebe mdb-ebeebe requested a review from a team as a code owner April 8, 2025 22:23
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ mdb-ebeebe
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant