Pax web 8 updates #1056
Open
Pax web 8 updates #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmgrens4
force-pushed
the
pax-web-8-updates
branch
from
1766729 to
a6739ab
Compare
| <version>5.2.19-SNAPSHOT</version> | ||
| </parent> | ||
| <artifactId>catalog-ui-reroute</artifactId> | ||
| <name>DDF :: Catalog :: UI :: Reroute</name> |
There was a problem hiding this comment.
❓ Is this still needed? Doesn't look like there is anything in this module
| @@ -88,7 +88,7 @@ | |||
|
|
|||
| <feature name="javalin" version="${project.version}" description="Javalin Web Framework"> | |||
| <feature prerequisite="true">wrap</feature> | |||
| <bundle>wrap:mvn:org.checkerframework/checker-qual/2.0.0$Bundle-Name=checker-qual&Bundle-SymbolicName=checker-qual&Bundle-Version=2.0.0&Export-Package=org.checkerframework.checker.nullness.qual;version="2.0.0"</bundle> | |||
| <!-- <bundle>wrap:mvn:org.checkerframework/checker-qual/2.0.0$Bundle-Name=checker-qual&Bundle-SymbolicName=checker-qual&Bundle-Version=2.0.0&Export-Package=org.checkerframework.checker.nullness.qual;version="2.0.0"</bundle>--> | |||
There was a problem hiding this comment.
This always gives me trouble when building. That being said there's a chance of runtime issues if this is excluded. I haven't tested enough to confirm it can be removed. It also doesn't seem to give anyone else trouble. So I think I'll leave it in for now, but if it starts causing build issues for anyone else I can revisit removing it.
alexabird
approved these changes
Apr 21, 2025
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
Suspected Failure(s):
|
derekwilhelm
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to pax web 8 there were major changes. Most changes adhere to the specifications defined by OSGI Http Whiteboard R7 (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html) with a few exceptions (see WAB exceptions/ordering here: ops4j/org.ops4j.pax.web@b6cf8ba and https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.war.html#d0e69887)
Servlet registration should follow the pattern specified by https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.servletcontext
Currently everything is registered to the
/path contexts (note it's an LDAP selection filter so ALL contexts with/as the path will have our servlets registered.Pathing resolution for servlets is now done based on that context.
WABs have now been turned to resource mappings with a welcome file (see: connexta/ace#144)