-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Add demo tutorial #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add demo tutorial #1412
Conversation
WalkthroughThe changes update the documentation by adding a new section in the README titled "Build your own Demo." This section expands the table of contents with an entry for a C++ demo tutorial, providing users with a concise guide on writing a demo in under 400 lines. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
153-156
: New “Build your own Demo” Section Introduced
The new section with header#### Build your own Demo
and the associated C++ tutorial link integrate well into the document. However, markdownlint has flagged an emphasis style warning on line 155: the tutorial description uses underscores for italics, while the expected style is asterisks. Consider replacing the underscores with asterisks for consistency with your project's Markdown conventions.Apply the following diff to fix the emphasis style:
-* [**C++**: _How to start writing an actual demo in <400 lines_](https://gargaj.github.io/demos-for-dummies/) +* [**C++**: *How to start writing an actual demo in <400 lines*](https://gargaj.github.io/demos-for-dummies/)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
155-155: Emphasis style
Expected: asterisk; Actual: underscore(MD049, emphasis-style)
155-155: Emphasis style
Expected: asterisk; Actual: underscore(MD049, emphasis-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
155-155: Emphasis style
Expected: asterisk; Actual: underscore
(MD049, emphasis-style)
155-155: Emphasis style
Expected: asterisk; Actual: underscore
(MD049, emphasis-style)
🔇 Additional comments (1)
README.md (1)
18-18
: New Table of Contents Entry for “Demo” Added
The new "Demo" entry in the Table of Contents is a clear and useful addition. Just verify that the link (#build-your-own-demo
) correctly points to the new section that is added later in the document.
This may be niche and may only pertain to demoscene enthusiasts, but still.
Summary by CodeRabbit