Skip to content

[ENH] Turn on spann by default #4351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Apr 22, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This is a placeholder PR that enables spann by default. It is just for testing if CI is green after all fixes have gone in.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia sanketkedia marked this pull request as ready for review April 22, 2025 20:06
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from f26839d to 352d95e Compare April 22, 2025 22:36
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from 69fb62a to df0a6e0 Compare April 22, 2025 22:36
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 352d95e to 3e08ad2 Compare April 22, 2025 23:16
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from df0a6e0 to 024fafe Compare April 22, 2025 23:16
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 3e08ad2 to c84100f Compare April 23, 2025 18:49
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from 024fafe to 010f494 Compare April 23, 2025 18:49
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from c84100f to b93d0ae Compare April 23, 2025 20:31
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch 2 times, most recently from b4ed698 to 062c06f Compare April 24, 2025 15:15
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from c436b2a to 2c996ad Compare April 24, 2025 18:59
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch 2 times, most recently from 645593c to 581bb70 Compare April 24, 2025 19:41
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 64cc766 to 514e6f8 Compare April 24, 2025 21:40
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from 581bb70 to 9dd6b08 Compare April 24, 2025 21:41
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 514e6f8 to 5ed6e01 Compare April 24, 2025 23:12
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from 9dd6b08 to ec5afb7 Compare April 24, 2025 23:12
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch 2 times, most recently from 7df1917 to f2fb1e9 Compare April 24, 2025 23:14
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from ec5afb7 to 2047e1b Compare April 24, 2025 23:15
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from f2fb1e9 to ff1a526 Compare April 24, 2025 23:58
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch 4 times, most recently from 2e37fa2 to 2fa1886 Compare April 25, 2025 01:08
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch 6 times, most recently from be405e5 to b5065bc Compare April 25, 2025 02:38
@sanketkedia sanketkedia changed the base branch from 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config to graphite-base/4351 April 25, 2025 03:35
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from 40cbc9a to 66051b7 Compare April 25, 2025 03:35
@graphite-app graphite-app bot changed the base branch from graphite-base/4351 to main April 25, 2025 03:36
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from 66051b7 to 054d3d7 Compare April 25, 2025 03:36
@sanketkedia sanketkedia force-pushed the 04-22-_enh_turn_on_spann_by_default branch from 054d3d7 to d05268f Compare April 25, 2025 05:42
@sanketkedia sanketkedia merged commit 5f17aaa into main Apr 25, 2025
70 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant