BUG: JS Client - Make embedding function parameter optional

[ArmanDris]

Description of changes

Referenced in issue: #3730

In the JS Client the embeddingFunction parameter for getCollection is optional, but in the type definition the ? is missing making the type checker think it is a mandatory parameter.

The docustring for getCollection, indicating that embeddingFunction is optional is here:

chroma/clients/js/packages/chromadb-core/src/ChromaClient.ts

Line 392 in 69dc794

* @param {IEmbeddingFunction} [params.embeddingFunction] - Optional custom embedding function for the collection.

Summarize the changes made by this PR.

• I changed embeddingFunction: IEmbeddingFunction; to embeddingFunction?: IEmbeddingFunction;

Test plan

How are these changes tested?

• No type errors when calling getCollection with just a name field
• The correct collection is returned when getCollection is called without an embeddingFunction

Documentation Changes

These changes make the code allign with the getCollection docustring, so no changes required.

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)