Skip to content

use /usr/bin/env #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

use /usr/bin/env #83

merged 1 commit into from
Apr 3, 2025

Conversation

eval-exec
Copy link
Contributor

@eval-exec eval-exec commented Apr 3, 2025

Since NixOS have no /bin/bash.

Ref: https://stackoverflow.com/a/16365367/14717438

@chase
Copy link
Owner

chase commented Apr 3, 2025

What distributions use something other than /bin/bash?

Alpine isn't supported at the moment because it uses muslc.

@SolitudeSF
Copy link

SolitudeSF commented Apr 3, 2025

chimera linux doesn't use bash. anyway, does it matter which distribution does? better to do the correct thing.

@chase
Copy link
Owner

chase commented Apr 3, 2025

chimera linux doesn't. anyway, does it matter which distribution does?

I appreciate the answer, it seems Chimera is based on muslc as well, so unfortunately it's also not supported.

Respectfully, yes it matters to me as the sole maintainer of this silly project. Let's not be combative about this.

No description was provided for this PR. I'd like to know what it fixes for the user who provided it. I'm asking so that I can have better context, since I noticed they also submitted a package request for Nix.

better to do the correct thing.

It would be more consistent, since it's already used in setup.sh.

@chase chase merged commit 20d5bbe into chase:electron Apr 3, 2025
@chase
Copy link
Owner

chase commented Apr 3, 2025

@eval-exec I appreciate your PR. Next time please provide a description as requested by the contribution guidelines:

  1. Make a pull request based on your fork, then in the description of the PR:
  • Describe clearly what features it contributes and why, or what bugs/issues it fixes

What does this fix for you, specifically?

@eval-exec
Copy link
Contributor Author

Thank you. I'm using NixOS, and NixOS have no /bin/bash.

@eval-exec
Copy link
Contributor Author

eval-exec commented Apr 4, 2025

@eval-exec I appreciate your PR. Next time please provide a description as requested by the contribution guidelines:

  1. Make a pull request based on your fork, then in the description of the PR:
  • Describe clearly what features it contributes and why, or what bugs/issues it fixes

What does this fix for you, specifically?

Lucky, It works my my kitty terminal on NixOS. but it not work on tmux(which is running under kitty):
image

When I run await under tmux: it's

awrit on  electron is 📦 v2.0.1 via  v20.18.3 on ☁️   took 1m8s
❯ ./awrit https://google.com
Extended keyboard support is required
awrit on  electron is 📦 v2.0.1 via  v20.18.3 on ☁️
❯ echo $?
0
awrit on  electron is 📦 v2.0.1 via  v20.18.3 on ☁️
❯ cat awrit_error.txt

(awrit_error.txt file is empty)


And it need use /usr/bin/env bash in ./await-native-rs/run-shim

eval-exec added a commit to eval-exec/awrit that referenced this pull request Apr 4, 2025
chase added a commit that referenced this pull request Apr 4, 2025
NixOS have no `/bin/bash`.

#83
@chase
Copy link
Owner

chase commented Apr 4, 2025

When I run await under tmux: it's

awrit on  electron is 📦 v2.0.1 via  v20.18.3 on ☁️   took 1m8s
❯ ./awrit https://google.com
Extended keyboard support is required
awrit on  electron is 📦 v2.0.1 via  v20.18.3 on ☁️
❯ echo $?
0
awrit on  electron is 📦 v2.0.1 via  v20.18.3 on ☁️
❯ cat awrit_error.txt

(awrit_error.txt file is empty)

And it need use /usr/bin/env bash in ./await-native-rs/run-shim

tmux is not supported: https://sw.kovidgoyal.net/kitty/faq/#i-am-using-tmux-and-have-a-problem

It probably won't be supported in the future because of several limitations that there's no reasonable workaround for while maintaining good performance and keyboard support:

You might be interested in this article to get the benefits of tmux out of kitty directly:

https://andrew.hau.st/blog/from-tmux-to-kitty/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants