Skip to content

refactor(configs): Update for Geth and Reth #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

refactor(configs): Update for Geth and Reth #447

wants to merge 22 commits into from

Conversation

wbnns
Copy link
Contributor

@wbnns wbnns commented Apr 24, 2025

This PR refactors and updates to the latest configs for Geth and Reth

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 24, 2025 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns marked this pull request as ready for review April 24, 2025 13:06
tobidae-cb
tobidae-cb reviewed Apr 24, 2025
View reviewed changes
tobidae-cb
tobidae-cb reviewed Apr 24, 2025
View reviewed changes
tobidae-cb
tobidae-cb reviewed Apr 24, 2025
View reviewed changes
tobidae-cb
tobidae-cb previously approved these changes Apr 24, 2025
View reviewed changes
danyalprout
danyalprout reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
0x00101010
0x00101010 reviewed Apr 24, 2025
View reviewed changes
@cb-heimdall cb-heimdall dismissed tobidae-cb’s stale review April 24, 2025 16:09

Approved review 2791185488 from tobidae-cb is now dismissed due to new commit. Re-request for approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyalprout danyalprout danyalprout left review comments

@0x00101010 0x00101010 0x00101010 left review comments

@tobidae-cb tobidae-cb tobidae-cb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wbnns @cb-heimdall @danyalprout @0x00101010 @tobidae-cb