-
Notifications
You must be signed in to change notification settings - Fork 112
fix asyncweb3 #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix asyncweb3 #112
Conversation
This depends on what version of web3py that @BobTheBuidler wants to target. The I would like to see some modernization of this library for Python itself, but web3py v7 has introduced a lot of changes throughout that people may not be prepared to upgrade. |
you're quick! what do you think about this?
|
Just specify in the docstring which web3py version(s) the change is for and then I'll merge. Thanks for this! |
source for the change being v7.0.0-beta.2 (2024-03-11): https://web3py.readthedocs.io/en/stable/release_notes.html |
if you're willing to bump the minimum web3py dependency to v7.0.0-beta.2 (or higher) then you can remove some of the AsyncWeb3 workarounds I think, like this one that does the |
I prefer to keep the deps as loose as possible here and leave that choice to the user. The above workaround is fine, this code does not run in tight loops as it is so efficiency isn't a huge deal. |
use middleware or middlewares argument as appropriate for the Web3py version
fixes: #110