fix: pick the start script for node projects before main property #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a regression that was caused by the cleanup of project detections
github-actions
bot
added
t-tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a regression that was caused by the cleanup of project detections, where we would default to the
mainproperty of the package.json instead of thestartscript like we used to. This was shown to be an issue in apify/actor-templates#392, which had a template with a main script that was invalid and incompatible with the runtime, while thestartscript would have worked.I've also added test fixtures to ensure certain issues that we've kept having no longer happen (windows + spaced paths breaking, invalid entrypoint configs correctly throw the expected errors or handle gracefully)