[SPARK-49488][SQL][FOLLOWUP] Do not push down extract expression if extracted field is second #50637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtracted field is second
|
ping @cloud-fan |
cloud-fan
approved these changes
Apr 22, 2025
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 22, 2025
…xtracted field is second ### What changes were proposed in this pull request? This PR aims to forbid the pushdown while extract `second` from date or interval. ### Why are the changes needed? Currently, Spark supports extract second from date or interval and it returns result with `decimal(8, 6)`. But extract second from date or interval returns integer in MySQL. So we should forbid the pushdown. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50637 from beliefer/SPARK-49488_f2. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c77b163) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
@cloud-fan Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to forbid the pushdown while extract
secondfrom date or interval.Why are the changes needed?
Currently, Spark supports extract second from date or interval and it returns result with
decimal(8, 6).But extract second from date or interval returns integer in MySQL.
So we should forbid the pushdown.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.