Skip to content

[SPARK-51699][BUILD] Upgrade to Apache parent pom 34 #50627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.5
Choose a base branch
from

Conversation

vrozov
Copy link
Member

@vrozov vrozov commented Apr 17, 2025

What changes were proposed in this pull request?

Upgrade Apache parent pom from version 18 to the latest version 34 along with upgrading few maven plugins versions to match those from the latest parent pom.

  • maven-enforcer-plugin from 3.3.0 to 3.5.0
  • maven-compiler-plugin from 3.11.0 to 3.14.0
  • maven-surefire-plugin from 3.1.2 to 3.5.2
  • maven-jar-plugin from 3.3.0 to 3.4.2
  • maven-source-plugin from 3.3.0 to 3.3.1
  • maven-clean-plugin from 3.3.1 to 3.4.1
  • maven-javadoc-plugin from 3.5.0 to 3.11.2
  • maven-assembly-plugin from 3.6.0 to 3.7.1
  • maven-shade-plugin from 3.5.0 to 3.6.0
  • maven-install-plugin from 3.1.1 to 3.1.4
  • maven-deploy-plugin from 3.1.1 to 3.1.4
  • maven-dependency-plugin from 3.6.0 to 3.8.1

Why are the changes needed?

Apache parent pom version 18 is 15 years old.

Does this PR introduce any user-facing change?

No

How was this patch tested?

maven build with Java 8 and Java 17

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot removed the BUILD label Apr 18, 2025
@vrozov vrozov marked this pull request as draft April 18, 2025 00:52
@github-actions github-actions bot added BUILD and removed INFRA labels Apr 18, 2025
@vrozov vrozov marked this pull request as ready for review April 18, 2025 05:18
yaooqinn
yaooqinn previously approved these changes Apr 18, 2025
@yaooqinn yaooqinn dismissed their stale review April 18, 2025 07:22

not for master

@yaooqinn
Copy link
Member

Hi @vrozov, thanks for the PR.

However, I have already merged #50500 to master/4.1.0.
I guess this PR won't be necessary as those related artifacts are all related to the build and release phases.

@vrozov
Copy link
Member Author

vrozov commented Apr 18, 2025

Hi @yaooqinn, the PR targets 3.5.x releases (branch-3.5).

@vrozov
Copy link
Member Author

vrozov commented Apr 24, 2025

@yaooqinn IMO, it will be beneficial to update 3.5 branch and build to use Apache parent pom that is not 15 years old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants