Skip to content

chore(deps): [DNM] bump zlib to v1.3.1 #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

aleksraiden
Copy link
Contributor

Bump zlib to v1.3.1 - https://github.com/madler/zlib/releases/tag/v1.3.1

Key changes:

  • Fix bug in inflateSync() for data held in bit buffer
  • Add LIT_MEM define to use more memory for a small deflate speedup
  • Add bounds checking to ERR_MSG() macro, used by zError()
  • Fix a bug in ZLIB_DEBUG compiles in check_match()

@aleksraiden
Copy link
Contributor Author

Dear community, @PragmaTwice @git-hulk @torwig - I'am not so familiar with cmake, could you please help me with this error:

==========================================================

CMake Error in build/_deps/zlib-src/CMakeLists.txt:

Target "zlibstatic" INTERFACE_INCLUDE_DIRECTORIES property contains path:

"/home/runner/work/kvrocks/kvrocks/build/_deps/zlib-src"

which is prefixed in the build directory.Target "zlibstatic"
INTERFACE_INCLUDE_DIRECTORIES property contains path:

"/home/runner/work/kvrocks/kvrocks/build/_deps/zlib-src"

which is prefixed in the source directory.

@PragmaTwice
Copy link
Member

Seems it's fixed in this commit madler/zlib@f1f503d.

Maybe we can wait for new releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants