WIP: Test against Java 24 #19514
Draft
WIP: Test against Java 24 #19514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade Scala to 2.13.16, in order to get a Java 24-compatible ASM version. Upgrade Gradle to 8.14, which is the first Java 24 compatible version. Upgrade spotbugs to 4.9.4. This is the minimum version that's both Java 24 compatible, and not affected by spotbugs/spotbugs#3320 Since the new spotbugs version introduces some extra checks, this commit excludes those warnings, without looking at whether they are real issues or false positives.
github-actions
bot
added
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: This PR still uses a Gradle 8.14 RC, and Spotbugs 4.9.4 has not
released yet, so testing it requires a local build.
Upgrade Scala to 2.13.16, in order to get a Java 24-compatible ASM
version.
Upgrade Gradle to 8.14, which is the first Java 24 compatible version.
Upgrade spotbugs to 4.9.4. This is the minimum version that's both Java
24 compatible, and not affected by
spotbugs/spotbugs#3320
Since the new spotbugs version introduces some extra checks, this commit
excludes those warnings, without looking at whether they are real issues
or false positives.
Addressing those warnings is left as future work, since the code is no
worse now than before the issues were highlighted.