MINOR: Move candidateClients set creation outside of task loop for StickyTaskAssignor #19511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorcanj
changed the title
lorcanj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the StickyTaskAssignor, a set of ProcessIds is created for any remaining
unassigned tasks, representing the clients that a task can be assigned to.
The set is currently created for each remaining taskId, however the set
created is not dependent on the remaining taskIds (unlike the
previousClientsForStandbyTask, which does use the taskId in its creation).
I have checked that the set is not mutated in the findBestClientForTask()
code path and run the unit tests applicable for this assignor.
This change ensures the set is only created once.