KAFKA-18752: Fix the warning of no-operation caused by slf4j in building kafka #19501
+34
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing kafka JIRA: KAFKA-18752 In KAFKA-18466 we remove the slf4j impl from runtime scope to fix the compatible issue (see apache#17373 (comment)). However, that also causes a side effect that in running some tasks slf4k can't find any provider as they are included to "release-only" We could fix this by adding releasOnly to class path
github-actions
bot
added
triage
|
Build output: |
m1a2st
reviewed
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-18752 In KAFKA-18466, we remove the slf4j impl from runtime
scope to fix the compatibility issue (see
#17373 (comment)).
However, that also causes a side effect: when running some tasks, slf4j
can't find any provider as they are included in "release-only". We could
fix this by adding releaseOnly to the class path.
This patch leverages the task collection API to enable specific tasks to
access
releaseOnlydependencies.