Skip to content

[FLINK-37308] Support pauseOrResumeSplits in HybridSource #26483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xccui
Copy link
Member

@xccui xccui commented Apr 19, 2025

What is the purpose of the change

This PR added the pauseOrResumeSplits implementation in HybridSourceReader.

Brief change log

Delegate it to the current reader.

Verifying this change

A new testPauseResumeCurrentSourceSplits test was added to HybridSourceReaderTest.java.

Also verified the change with a production job.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 19, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for pausing or resuming splits in the HybridSourceReader by delegating the request to the current underlying reader. It also introduces a new test to validate the behavior.

  • Implement pauseOrResumeSplits in HybridSourceReader.
  • Add testPauseResumeCurrentSourceSplits in HybridSourceReaderTest.
  • Update import statements to support the new method signature.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
HybridSourceReaderTest.java Added a test that verifies pause and resume propagation to the underlying reader.
HybridSourceReader.java Delegated the pauseOrResumeSplits call to the current reader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants