[FLINK-37695][table] Fix parsing for built-in function JSON in JSON_OBJECT for all positions

[gustavodemorais]

What is the purpose of the change

Parsing for a JSON() function call fails if its position is not the first param of JSON_OBJECT.

SELECT JSON_OBJECT('key' VALUE JSON('{}'), 'key_2' VALUE JSON('{}'));

Outputs:

The JSON() function is currently only supported inside a JSON_OBJECT() or JSON_ARRAY() function. Example: JSON_OBJECT('a', JSON('{\"key\": \"value\"}')) or JSON_ARRAY(JSON('{\"key\": \"value\"}'))

This is incorrect, we were too strict with the limitations. We're strictly allowing json to be called only as the second param in the function, when it should be allowed for every second.

Brief change log

(for example:)

• Check if the JSON call is for any of the VALUES param inside a JSON_OBJECT and not only the first one

Verifying this change

This change added tests and can be verified as follows:

• Added unit tests

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (already covered by docs / JavaDocs)

[flinkbot]

CI report:

• 8396f7e Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[snuyanzin]

i wonder whether we can extract the whole if condition into method something like isJsonOperand

[gustavodemorais]

Created a helper function called isSupportedJsonOperand

[snuyanzin]

I think we can drop this method if we extract the whole if condition into a method.

Also about naming: it might make confused some people since in SQL there is also VALUES and this method has nothing to do with it

[gustavodemorais]

I renamed it to inValuesParamOfJsonObject? I think the code is more readable if you read inValuesParamOfJsonObject as part of the if condition than i%2