[fix](json-functions)fix json-replace/insert/set/array behavior with complex type #50308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
Merged
16 tasks
TPC-H: Total hot run time: 33763 ms |
TPC-DS: Total hot run time: 184885 ms |
ClickBench: Total hot run time: 29.97 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
reviewed
Apr 22, 2025
| List<DataType> arguments = new ArrayList<>(); | ||
| arguments.add(VarcharType.SYSTEM_DEFAULT); // json_str | ||
| for (int i = 1; i < arity(); i++) { | ||
| if ((i & 1) == 0 && (getArgumentType(i).isComplexType() || getArgumentType(i).isJsonType())) { |
There was a problem hiding this comment.
(i & 1) == 0 determines the even position, which exactly corresponds to the position of the value parameter. pass the origin value type to BE and should not cast to varchar
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
924060929
approved these changes
Apr 23, 2025
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run feut |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
…complex type (#50308) ### What problem does this PR solve? here are some functions behavior is not same with mysql as JSON_REPLACE | JSON_INSERT | JSON_SET | JSON_ARRAY which json and complex types are not supported before this PR Follow mysql : https://dev.mysql.com/doc/refman/8.0/en/json-modification-functions.html#function_json-set before we will meet result: ``` mysql> insert into t01 values (1, '{"a":1, "b":2}'); Query OK, 1 row affected (0.25 sec) {'label':'label_1056456f8d8c46e5_9be38bb344bdd72c', 'status':'VISIBLE', 'txnId':'8019'} mysql> select b, json_set(b, "$.a", b) from t01; +---------------+-----------------------+ | b | json_set(b, "$.a", b) | +---------------+-----------------------+ | {"a":1,"b":2} | {"a":1,"b":2} | +---------------+-----------------------+ ``` now ``` mysql> select b, json_set(b, "$.a", b) from t01; +---------------+---------------------------+ | b | json_set(b, "$.a", b) | +---------------+---------------------------+ | {"a":1,"b":2} | {"a":{"a":1,"b":2},"b":2} | +---------------+---------------------------+ 1 row in set (0.12 sec) ```
yiguolei
pushed a commit
that referenced
this pull request
Apr 24, 2025
…complex type #50308 (#50309) ### What problem does this PR solve? backport: #50308 Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
here are some functions behavior is not same with mysql as JSON_REPLACE | JSON_INSERT | JSON_SET | JSON_ARRAY
which json and complex types are not supported before this PR
Follow mysql : https://dev.mysql.com/doc/refman/8.0/en/json-modification-functions.html#function_json-set
before we will meet result:
now
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)