-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[chore] Add Clang 18/19 Support #47438 #50300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support to compile Doris backend with Clang 19. I've tested this PR with both Clang 16 and Clang 19 using: ```bash env DISABLE_BUILD_AZURE=1 ./build.sh --be --clean ``` *(Azure was disabled due to challenges patching deps in `azure-sdk-for-cpp-azure-core_1.10.3` via vcpkg.)* I've released a new toolchain with GCC 14 and Clang 19 here: [ldb_toolchain](https://github.com/amosbird/ldb_toolchain_gen/releases/tag/v0.23). Happy New Year to the Doris community! 🎉 - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run buildall |
run buildall |
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
run buildall |
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Apr 23, 2025
BiteTheDDDDt
added a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Apr 23, 2025
pick and modified from apache#47438 --------- Co-authored-by: Amos Bird <amosbird@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick and modified from #47438