Skip to content

[chore](function) remove some unused close function #50285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Apr 22, 2025

What problem does this PR solve?

Problem Summary:
remove some unused override close function, it's not usefully

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33623 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6a839c49df12bd801eb4d8734235a198b50d7263, data reload: false

------ Round 1 ----------------------------------
q1	26256	5085	4975	4975
q2	2072	283	176	176
q3	10541	1254	688	688
q4	10233	1047	531	531
q5	7712	2405	2303	2303
q6	186	165	131	131
q7	930	735	608	608
q8	9326	1331	1086	1086
q9	6818	5124	5157	5124
q10	6824	2329	1892	1892
q11	471	270	276	270
q12	349	351	215	215
q13	17762	3630	3050	3050
q14	223	213	213	213
q15	533	477	484	477
q16	462	439	393	393
q17	588	846	369	369
q18	7723	7283	7014	7014
q19	1505	946	535	535
q20	337	334	221	221
q21	3923	2683	2408	2408
q22	1049	1012	944	944
Total cold run time: 115823 ms
Total hot run time: 33623 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5084	4998	5041	4998
q2	236	339	223	223
q3	2175	2646	2273	2273
q4	1460	1877	1422	1422
q5	4509	4445	4377	4377
q6	211	165	127	127
q7	1908	1915	1744	1744
q8	2597	2599	2513	2513
q9	7149	7153	7202	7153
q10	3018	3185	2724	2724
q11	581	507	489	489
q12	669	778	626	626
q13	3535	3916	3258	3258
q14	273	291	270	270
q15	527	474	484	474
q16	454	506	473	473
q17	1142	1583	1369	1369
q18	7578	7579	7463	7463
q19	792	801	927	801
q20	1969	2061	1868	1868
q21	5179	4765	4589	4589
q22	1054	1047	980	980
Total cold run time: 52100 ms
Total hot run time: 50214 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185229 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6a839c49df12bd801eb4d8734235a198b50d7263, data reload: false

query1	1015	484	521	484
query2	6585	1825	1794	1794
query3	6746	216	219	216
query4	26072	23777	23361	23361
query5	4335	591	475	475
query6	303	193	197	193
query7	4623	483	286	286
query8	293	254	244	244
query9	8646	2572	2574	2572
query10	479	324	280	280
query11	15238	15027	14798	14798
query12	181	115	105	105
query13	1645	515	395	395
query14	8570	6107	6120	6107
query15	216	192	179	179
query16	7120	639	472	472
query17	918	702	549	549
query18	1958	398	304	304
query19	181	190	157	157
query20	120	114	119	114
query21	209	120	102	102
query22	4005	4109	4094	4094
query23	33773	32922	32869	32869
query24	8496	2336	2365	2336
query25	525	485	417	417
query26	1246	264	151	151
query27	2762	489	330	330
query28	4364	2110	2099	2099
query29	777	558	440	440
query30	282	223	185	185
query31	928	837	767	767
query32	73	62	64	62
query33	565	373	316	316
query34	784	849	518	518
query35	799	820	743	743
query36	972	992	909	909
query37	112	103	80	80
query38	4140	4109	4044	4044
query39	1610	1432	1385	1385
query40	211	125	113	113
query41	60	59	58	58
query42	128	113	113	113
query43	495	495	471	471
query44	1294	817	823	817
query45	188	175	180	175
query46	832	1001	624	624
query47	1760	1836	1709	1709
query48	386	423	304	304
query49	818	524	435	435
query50	648	663	394	394
query51	4057	4129	4049	4049
query52	109	112	104	104
query53	229	247	185	185
query54	583	589	513	513
query55	91	83	85	83
query56	351	341	303	303
query57	1097	1151	1077	1077
query58	279	294	252	252
query59	2546	2600	2456	2456
query60	328	317	314	314
query61	134	132	126	126
query62	804	750	653	653
query63	235	193	187	187
query64	4395	993	681	681
query65	4317	4213	4226	4213
query66	1146	404	300	300
query67	15613	15306	15260	15260
query68	8845	877	518	518
query69	476	302	263	263
query70	1208	1143	1066	1066
query71	463	310	301	301
query72	5663	4709	4687	4687
query73	718	593	344	344
query74	8828	9136	8619	8619
query75	4164	3191	2681	2681
query76	3623	1176	746	746
query77	802	367	292	292
query78	9978	10226	9223	9223
query79	1530	824	566	566
query80	601	533	441	441
query81	466	254	223	223
query82	409	125	98	98
query83	261	255	236	236
query84	293	98	83	83
query85	848	354	311	311
query86	335	302	267	267
query87	4433	4448	4341	4341
query88	2890	2230	2236	2230
query89	386	313	283	283
query90	1912	220	217	217
query91	138	141	112	112
query92	77	61	57	57
query93	1033	948	581	581
query94	672	400	286	286
query95	372	287	282	282
query96	493	552	279	279
query97	3129	3233	3127	3127
query98	233	206	208	206
query99	1470	1420	1362	1362
Total cold run time: 271549 ms
Total hot run time: 185229 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a839c49df12bd801eb4d8734235a198b50d7263, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.26	0.19	0.20
query4	1.61	0.19	0.19
query5	0.60	0.60	0.60
query6	1.20	0.71	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.57	0.53	0.52
query10	0.59	0.59	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	1.17	1.18	1.20
query15	0.87	0.86	0.86
query16	0.37	0.38	0.37
query17	1.01	1.07	1.00
query18	0.22	0.20	0.20
query19	1.93	1.84	1.80
query20	0.01	0.01	0.02
query21	15.41	0.87	0.55
query22	0.78	1.40	0.73
query23	14.74	1.41	0.62
query24	6.82	1.52	0.44
query25	0.41	0.19	0.07
query26	0.68	0.16	0.15
query27	0.05	0.06	0.05
query28	9.01	0.91	0.44
query29	12.59	4.02	3.30
query30	0.26	0.11	0.06
query31	2.82	0.59	0.38
query32	3.23	0.56	0.47
query33	3.18	3.00	3.07
query34	15.72	5.09	4.47
query35	4.48	4.50	4.49
query36	0.68	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 102.89 s
Total hot run time: 29.2 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.55% (14528/27131)
Line Coverage 42.37% (125993/297342)
Region Coverage 41.19% (64399/156346)
Branch Coverage 35.78% (32385/90522)

@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33770 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6a839c49df12bd801eb4d8734235a198b50d7263, data reload: false

------ Round 1 ----------------------------------
q1	25798	5140	5043	5043
q2	2057	284	188	188
q3	10399	1222	673	673
q4	10221	1007	530	530
q5	7546	2463	2315	2315
q6	179	163	131	131
q7	904	720	613	613
q8	9319	1296	1101	1101
q9	6732	5045	5027	5027
q10	6846	2288	1907	1907
q11	490	275	275	275
q12	358	354	226	226
q13	17791	3666	3126	3126
q14	220	227	201	201
q15	547	475	484	475
q16	438	444	409	409
q17	573	845	352	352
q18	7725	7002	7019	7002
q19	1362	939	559	559
q20	335	330	215	215
q21	3788	3512	2406	2406
q22	1077	1007	996	996
Total cold run time: 114705 ms
Total hot run time: 33770 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5062	5067	5040	5040
q2	243	323	238	238
q3	2143	2646	2281	2281
q4	1458	1824	1409	1409
q5	4403	4432	4442	4432
q6	215	175	125	125
q7	1949	1945	1808	1808
q8	2584	2579	2517	2517
q9	7212	7113	6902	6902
q10	2992	3183	2755	2755
q11	577	522	500	500
q12	698	757	621	621
q13	3484	3879	3301	3301
q14	268	307	265	265
q15	507	484	482	482
q16	482	531	470	470
q17	1148	1513	1415	1415
q18	8011	7863	7675	7675
q19	814	863	945	863
q20	2006	1974	1846	1846
q21	5201	4860	4750	4750
q22	1096	1049	1019	1019
Total cold run time: 52553 ms
Total hot run time: 50714 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191902 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6a839c49df12bd801eb4d8734235a198b50d7263, data reload: false

query1	1406	1081	1066	1066
query2	6346	1790	1784	1784
query3	11037	4616	4559	4559
query4	53734	25385	23043	23043
query5	5215	531	470	470
query6	357	213	195	195
query7	4961	487	280	280
query8	297	230	237	230
query9	5896	2538	2551	2538
query10	425	325	264	264
query11	15149	15095	14772	14772
query12	162	107	105	105
query13	1081	513	395	395
query14	10065	6346	6382	6346
query15	197	191	175	175
query16	7011	620	478	478
query17	1066	727	576	576
query18	1553	409	309	309
query19	191	204	164	164
query20	122	126	120	120
query21	215	124	106	106
query22	4406	4471	4238	4238
query23	34120	33664	33639	33639
query24	6715	2395	2425	2395
query25	492	500	395	395
query26	674	272	157	157
query27	2142	494	334	334
query28	2999	2125	2111	2111
query29	559	566	432	432
query30	276	219	196	196
query31	890	881	773	773
query32	74	62	67	62
query33	462	370	302	302
query34	772	856	523	523
query35	795	848	752	752
query36	944	1019	913	913
query37	119	103	82	82
query38	4199	4290	4189	4189
query39	1513	1470	1457	1457
query40	214	119	132	119
query41	61	63	52	52
query42	114	107	115	107
query43	511	506	476	476
query44	1318	817	824	817
query45	181	173	164	164
query46	846	1045	662	662
query47	1853	1846	1790	1790
query48	390	419	302	302
query49	711	508	438	438
query50	659	717	411	411
query51	4165	4255	4179	4179
query52	116	106	104	104
query53	227	267	184	184
query54	619	585	507	507
query55	83	83	84	83
query56	313	308	309	308
query57	1166	1223	1107	1107
query58	270	274	257	257
query59	2617	2675	2607	2607
query60	318	325	308	308
query61	133	125	123	123
query62	731	752	696	696
query63	222	185	201	185
query64	1468	1069	773	773
query65	4319	4214	4284	4214
query66	734	400	304	304
query67	15818	15560	15274	15274
query68	6800	882	515	515
query69	536	308	260	260
query70	1173	1116	1062	1062
query71	483	311	286	286
query72	5977	4787	4921	4787
query73	1255	652	350	350
query74	9133	8901	8617	8617
query75	3407	3225	2714	2714
query76	3914	1179	748	748
query77	544	373	277	277
query78	9933	9913	9284	9284
query79	2380	817	598	598
query80	687	508	440	440
query81	482	253	215	215
query82	443	131	91	91
query83	249	248	228	228
query84	286	108	79	79
query85	765	353	307	307
query86	392	300	285	285
query87	4398	4434	4360	4360
query88	3339	2221	2228	2221
query89	410	320	278	278
query90	1752	211	211	211
query91	138	134	106	106
query92	71	64	56	56
query93	2110	945	582	582
query94	726	416	280	280
query95	367	335	282	282
query96	484	566	274	274
query97	3166	3181	3114	3114
query98	233	210	210	210
query99	1689	1374	1309	1309
Total cold run time: 296536 ms
Total hot run time: 191902 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a839c49df12bd801eb4d8734235a198b50d7263, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.12
query3	0.25	0.20	0.19
query4	1.60	0.20	0.20
query5	0.60	0.59	0.59
query6	1.19	0.73	0.71
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.53	0.51
query10	0.57	0.57	0.56
query11	0.15	0.11	0.12
query12	0.15	0.11	0.11
query13	0.61	0.60	0.60
query14	1.20	1.17	1.18
query15	0.89	0.86	0.85
query16	0.37	0.37	0.39
query17	1.03	1.01	0.99
query18	0.22	0.20	0.20
query19	1.88	1.82	1.82
query20	0.02	0.01	0.01
query21	15.40	0.92	0.54
query22	0.75	1.20	0.69
query23	14.90	1.40	0.66
query24	6.81	1.76	0.68
query25	0.46	0.28	0.08
query26	0.56	0.17	0.13
query27	0.05	0.05	0.05
query28	9.38	0.88	0.43
query29	12.58	3.97	3.35
query30	0.25	0.09	0.07
query31	2.82	0.59	0.38
query32	3.23	0.55	0.47
query33	3.10	3.11	3.05
query34	15.72	5.06	4.47
query35	4.52	4.55	4.47
query36	0.68	0.50	0.48
query37	0.08	0.07	0.06
query38	0.06	0.04	0.04
query39	0.02	0.02	0.03
query40	0.17	0.14	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.23 s
Total hot run time: 29.5 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.53% (14527/27138)
Line Coverage 42.34% (125979/297507)
Region Coverage 41.17% (64391/156418)
Branch Coverage 35.75% (32372/90562)

@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 4be0d69 into apache:master Apr 23, 2025
29 of 32 checks passed
@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants