Skip to content

Advanced use of vcpkg through manifest mode #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,6 @@ Production

**/.vscode
**/.vs

#vcpkg
vcpkg_installed
65 changes: 15 additions & 50 deletions INSTALL.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,68 +70,33 @@ In the scope of AliceVision, vcpkg has only been tested on Windows.

1. Install vcpkg

See the reference [installation guide](https://github.com/alicevision/vcpkg/blob/alicevision_master/README.md#quick-start-windows) to setup vcpkg.
We recommend to use our vcpkg fork, where dependencies have been validated by the AliceVision development team and where some ports may have some custom changes.
```bash
git clone https://github.com/alicevision/vcpkg --branch alicevision_master
git clone https://github.com/microsoft/vcpkg
cd vcpkg
.\bootstrap-vcpkg.bat
```

2. Build the required dependencies
```bash
cd <VCPKG_INSTALL_DIR>
set VCPKG_ROOT=%cd%

vcpkg install ^
boost-algorithm boost-accumulators boost-atomic boost-container boost-date-time boost-exception ^
boost-geometry boost-graph boost-json boost-log boost-program-options boost-property-tree ^
boost-ptr-container boost-regex boost-serialization boost-system boost-test boost-thread boost-timer ^
boost-format ^
lz4 ^
liblemon ^
openexr ^
alembic ^
geogram ^
eigen3 ^
expat ^
flann nanoflann ^
onnxruntime-gpu ^
opencv[eigen,ffmpeg,webp,contrib,nonfree,cuda] ^
openimageio[opencolorio,pybind11,libraw,ffmpeg,freetype,opencv,gif,openjpeg,webp] ^
openmesh ^
ceres[suitesparse,cxsparse] ^
cuda ^
tbb ^
assimp ^
pcl ^
clp ^
libe57format ^
vcpkg-tool-swig ^
--triplet x64-windows

%VCPKG_ROOT%/installed/x64-windows/tools/python3/python -m ensurepip --upgrade
%VCPKG_ROOT%/installed/x64-windows/tools/python3/python -m pip install numpy
```
2. Build

3. Build AliceVision
```bash
# With VCPKG_ROOT being the path to the root of vcpkg installation
cd /path/to/aliceVision/
mkdir build && cd build
* Open "x64 Native Tools command Prompt for VS 2022" shipped with Visual studio 2022
* Move to the aliceVision root directory
* Build the dependencies and generate the solution for building (This command may take a long time the first time as it is building and installing all the required dependencies from sources.)

# Windows: Visual 2022 + Powershell
cmake .. -DCMAKE_TOOLCHAIN_FILE="$env:VCPKG_ROOT"\scripts\buildsystems\vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x64-windows -G "Visual Studio 17 2022" -A x64 -T host=x64
```bash
cmake -B build -S . -DCMAKE_TOOLCHAIN_FILE=c:\path_to_vcpkg\scripts\buildsystems\vcpkg.cmake -DCMAKE_INSTALL_PREFIX=c:\path_to_install -DVCPKG_TARGET_TRIPLET=x64-windows-release -G "Visual Studio 17 2022" -A x64 -T host=x64 -DALICEVISION_BUILD_SWIG_BINDING=ON -DALICEVISION_USE_OPENCV=OFF -DPython3_EXECUTABLE=c:\path_to_python\python.exe
```

# Windows: Visual 2022
cmake .. -DCMAKE_TOOLCHAIN_FILE=%VCPKG_ROOT%\scripts\buildsystems\vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x64-windows -G "Visual Studio 17 2022" -A x64 -T host=x64
* Effectively build AliceVision and install it to `c:\path_to_install`

# Windows: Visual 2017
cmake .. -DCMAKE_TOOLCHAIN_FILE=%VCPKG_ROOT%\scripts\buildsystems\vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x64-windows -G "Visual Studio 15 2017" -A x64 -T host=x64
```bash
cmake --build build --config Release -t INSTALL
```

This generates a "aliceVision.sln" solution inside the build folder that you can open in Visual Studio to launch the build. Do not forget to switch the build type to "Release".
* Generate the bundle with all the dependencies in the same directory

```bash
cmake --build build --config Release -t bundle
```

Building the project with embedded dependencies (recommended on linux)
-----------------------------------------------
Expand Down
22 changes: 22 additions & 0 deletions vcpkg-configuration.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"default-registry": {
"kind": "git",
"baseline": "d5182f703b51d7b258f83f94d936ac03488dcdbe",
"repository": "https://github.com/microsoft/vcpkg"
},
"registries": [
{
"kind": "artifact",
"location": "https://github.com/microsoft/vcpkg-ce-catalog/archive/refs/heads/main.zip",
"name": "microsoft"
},
{
"kind": "filesystem",
"path": "./vcpkg",
"packages": ["vcpkg-tool-swig"]
}
],
"overlay-ports": [
"vcpkg/overlay_ports"
]
}
89 changes: 89 additions & 0 deletions vcpkg.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
{
"dependencies": [
"boost-algorithm",
"boost-accumulators",
"boost-atomic",
"boost-container",
"boost-date-time",
"boost-exception",
"boost-geometry",
"boost-graph",
"boost-json",
"boost-log",
"boost-program-options",
"boost-property-tree",
"boost-ptr-container",
"boost-regex",
"boost-serialization",
"boost-system",
"boost-test",
"boost-thread",
"boost-timer",
"boost-format",
"libe57format",
"assimp",
"openexr",
"alembic",
"geogram",
"eigen3",
"expat",
"flann",
"nanoflann",
"onnxruntime-gpu",
"openmesh",
"tbb",
"cuda",
"liblemon",
"clp",
"coinutils",
"osi",
"vcpkg-tool-swig",
{
"name":"openimageio",
"features": ["opencolorio","libraw","gif","openjpeg"]
},
{
"name":"ceres",
"features": ["suitesparse"]
},
{
"name": "opencv",
"features": ["eigen", "ffmpeg", "contrib", "nonfree", "cuda"],
"default-features": false
}
],
"overrides": [
{
"name": "openimageio",
"version": "2.5.16.0"
},
{
"name": "suitesparse",
"version": "5.8.0"
},
{
"name": "opencv",
"version": "4.10.0#0"
},
{
"name": "liblemon",
"version": "2019-06-13#10"
},
{
"name": "clp",
"version": "1.17.6#1"
},
{
"name": "osi",
"version": "0.108.6#1"
},
{
"name": "coinutils",
"version": "2.11.4#1"
},
{
"name": "ceres",
"version": "2.2.0#0"
}
]
}
13 changes: 13 additions & 0 deletions vcpkg/overlay_ports/liblemon/cpp-20-adaptors.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/lemon/adaptors.h b/lemon/adaptors.h
index 1a40f8e..ffeb12d 100644
--- a/lemon/adaptors.h
+++ b/lemon/adaptors.h
@@ -37,7 +37,7 @@

namespace lemon {

-#ifdef _MSC_VER
+#if defined _MSC_VER and __cplusplus < 202002L
#define LEMON_SCOPE_FIX(OUTER, NESTED) OUTER::NESTED
#else
#define LEMON_SCOPE_FIX(OUTER, NESTED) typename OUTER::template NESTED
106 changes: 106 additions & 0 deletions vcpkg/overlay_ports/liblemon/cpp-20-arraymap.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
diff --git a/lemon/bits/array_map.h b/lemon/bits/array_map.h
index 355ee00..c3992cf 100644
--- a/lemon/bits/array_map.h
+++ b/lemon/bits/array_map.h
@@ -88,7 +88,7 @@ namespace lemon {
Item it;
for (nf->first(it); it != INVALID; nf->next(it)) {
int id = nf->id(it);;
- allocator.construct(&(values[id]), Value());
+ std::allocator_traits<Allocator>::construct(allocator, &(values[id]), Value());
}
}

@@ -102,7 +102,7 @@ namespace lemon {
Item it;
for (nf->first(it); it != INVALID; nf->next(it)) {
int id = nf->id(it);;
- allocator.construct(&(values[id]), value);
+ std::allocator_traits<Allocator>::construct(allocator, &(values[id]), value);
}
}

@@ -121,7 +121,7 @@ namespace lemon {
Item it;
for (nf->first(it); it != INVALID; nf->next(it)) {
int id = nf->id(it);;
- allocator.construct(&(values[id]), copy.values[id]);
+ std::allocator_traits<Allocator>::construct(allocator, &(values[id]), copy.values[id]);
}
}

@@ -218,15 +218,15 @@ namespace lemon {
for (nf->first(it); it != INVALID; nf->next(it)) {
int jd = nf->id(it);;
if (id != jd) {
- allocator.construct(&(new_values[jd]), values[jd]);
- allocator.destroy(&(values[jd]));
+ std::allocator_traits<Allocator>::construct(allocator, &(new_values[jd]), values[jd]);
+ std::allocator_traits<Allocator>::destroy(allocator, &(values[jd]));
}
}
if (capacity != 0) allocator.deallocate(values, capacity);
values = new_values;
capacity = new_capacity;
}
- allocator.construct(&(values[id]), Value());
+ std::allocator_traits<Allocator>::construct(allocator, &(values[id]), Value());
}

// \brief Adds more new keys to the map.
@@ -260,8 +260,8 @@ namespace lemon {
}
}
if (found) continue;
- allocator.construct(&(new_values[id]), values[id]);
- allocator.destroy(&(values[id]));
+ std::allocator_traits<Allocator>::construct(allocator, &(new_values[id]), values[id]);
+ std::allocator_traits<Allocator>::destroy(allocator, &(values[id]));
}
if (capacity != 0) allocator.deallocate(values, capacity);
values = new_values;
@@ -269,7 +269,7 @@ namespace lemon {
}
for (int i = 0; i < int(keys.size()); ++i) {
int id = nf->id(keys[i]);
- allocator.construct(&(values[id]), Value());
+ std::allocator_traits<Allocator>::construct(allocator, &(values[id]), Value());
}
}

@@ -279,7 +279,7 @@ namespace lemon {
// and it overrides the erase() member function of the observer base.
virtual void erase(const Key& key) {
int id = Parent::notifier()->id(key);
- allocator.destroy(&(values[id]));
+ std::allocator_traits<Allocator>::destroy(allocator, &(values[id]));
}

// \brief Erase more keys from the map.
@@ -289,7 +289,7 @@ namespace lemon {
virtual void erase(const std::vector<Key>& keys) {
for (int i = 0; i < int(keys.size()); ++i) {
int id = Parent::notifier()->id(keys[i]);
- allocator.destroy(&(values[id]));
+ std::allocator_traits<Allocator>::destroy(allocator, &(values[id]));
}
}

@@ -303,7 +303,7 @@ namespace lemon {
Item it;
for (nf->first(it); it != INVALID; nf->next(it)) {
int id = nf->id(it);;
- allocator.construct(&(values[id]), Value());
+ std::allocator_traits<Allocator>::construct(allocator, &(values[id]), Value());
}
}

@@ -317,7 +317,7 @@ namespace lemon {
Item it;
for (nf->first(it); it != INVALID; nf->next(it)) {
int id = nf->id(it);
- allocator.destroy(&(values[id]));
+ std::allocator_traits<Allocator>::destroy(allocator, &(values[id]));
}
allocator.deallocate(values, capacity);
capacity = 0;
Loading
Loading