Skip to content

Split logging features of fastapi_log #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 16.0-add-fastapi_log
Choose a base branch
from

Conversation

SirPyTech
Copy link

@SirPyTech SirPyTech commented Apr 23, 2025

As suggested in

Thanks for working on this. I wanted to do it since a while 😅

Early feedback...

The way I was planning to handle this was to have a base module to collect any kind of "request/response log".
This can be used by fastapi, base_rest, edi framework, endpoints and any custom implementation of request/response feature.

Would you consider splitting this part to a module like request_log or something like that?

Originally posted by @simahawk in OCA#501 (comment)

Also add the module fastapi_log_mail to optionally send an email when an exception occurs.

Depends on:

This way other APIs might use the new module `api_log` to store logs.
@ak-git-bot
Copy link

Hi @paradoxxxzero,
some modules you are maintaining are being modified, check this out!

@SirPyTech SirPyTech force-pushed the 16.0-add-fastapi_log branch from 1e08ade to ff9d6af Compare April 28, 2025 09:48
@SirPyTech SirPyTech marked this pull request as draft April 28, 2025 09:54
@SirPyTech SirPyTech force-pushed the 16.0-add-fastapi_log branch from ff9d6af to 1e08ade Compare April 28, 2025 09:57
@SirPyTech SirPyTech marked this pull request as ready for review April 28, 2025 10:05
@PicchiSeba
Copy link

PicchiSeba commented Apr 30, 2025

Regarding the multi-slash PR maybe we should wait to include it in its entirety until we receive some feedback (and I implement some tests).

I could extract the get_endpoint method without the multi-slash part and put it in its own PR and then apply my PR on it.
This way we have a common method to work on.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants