style(tabs): added sp-tabs-overflow mod tokens #5386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e577c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsChrometabs permalinkbasic-test
Firefoxtabs permalinkbasic-test
|
Rajdeepc
reviewed
Apr 22, 2025
Comment on lines
+17
to
+34
| --sp-tabs-overflow-next-button-right: var( | ||
| --mod-sp-tabs-overflow-next-button-right, | ||
| calc(-1 * var(--spectrum-component-edge-to-text-100)) | ||
| ); | ||
| --sp-tabs-overflow-previous-button-left: calc( | ||
| -1 * var(--spectrum-component-edge-to-text-100) | ||
| --sp-tabs-overflow-previous-button-left: var( | ||
| --mod-sp-tabs-overflow-previous-button-left, | ||
| calc(-1 * var(--spectrum-component-edge-to-text-100)) | ||
| ); | ||
| --sp-tabs-overflow-button-height: calc( | ||
| var(--spectrum-tab-item-height-medium) - | ||
| var(--spectrum-border-width-200) | ||
| ); | ||
| --sp-tabs-overflow-button-size: var(--spectrum-tab-item-height-medium); | ||
| --sp-tabs-overflow-icon-color: var(--spectrum-gray-800); | ||
| --sp-tabs-overflow-shadow-color: var(--spectrum-gray-100); | ||
| --sp-tabs-overflow-shadow-color: var( | ||
| --mod-sp-tabs-overflow-shadow-color, | ||
| var(--spectrum-gray-100) | ||
| ); |
There was a problem hiding this comment.
This is a temporary fix and is against the mod inheritance property contract. Please reach out to the channel for better support from the spectrum-css team.
There was a problem hiding this comment.
This component is not in spectrum-css as far as I'm aware. Shouldn't we add these --mod tokens here?
|
We are going to close this after a discussion in slack. The horizon team is developing their own style of tabs so this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some --mod tokens to the sp-tabs-overflow component's styles to allow further customization.
Added --mod tokens to allow customization of:
--mod-sp-tabs-overflow-next-button-right)--mod-sp-tabs-overflow-previous-button-left)--mod-sp-tabs-overflow-shadow-color)Related issue(s)
Motivation and context
With the current styling, this can have an undesired look when the sp-tabs-overflow element does not ocupy the whole width of the parent.
The change will allow for looks similar to this one (see that the gradient fades into the background)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.