fix ios crash on capture #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was caused by the original and non idiomatic way to call capture and was overlooked when capture and view got fixed
|
@jorgemasta @sejas could we please get this PR merged and released? It works well for us :) |
|
@Tweenkie I think I'm experiencing this same issue. My app in capture instead of crashing seems to freeze. No error messages or crash logs show. what behavior were you experiencing? |
|
This worked for me as well in debug. Why hasn't it been merged? Are there issues I should consider in prod? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was caused by the original and non idiomatic way to call capture and was overlooked when capture and view got fixed