Add a HeapSnapshotAnalysis pass #7486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome and Edge DevTools can capture heap snapshots, which are JSON representations of the entire object graph at a moment in time. Add a pass that can parse such a snapshot and report statistics about how much of the heap is occupied by Wasm objects and what the top types are by cumulative heap size and allocation count.
|
I'll add a test for this before we land it. I'm also open to suggestions of interesting analyses to run. I don't have a heap snapshot of a module with a name section, but eventually I would like to support printing details of the type definitions when I can match up names in the snapshot to names in the module. |
kripken
reviewed
Apr 14, 2025
| #include "support/file.h" | ||
| #include "support/json.h" | ||
| #include "wasm.h" | ||
|
|
There was a problem hiding this comment.
Please add a comment explaining the pass.
| @@ -220,6 +220,10 @@ void PassRegistry::registerPasses() { | |||
| createTypeRefiningGUFAPass); | |||
| registerPass( | |||
| "heap2local", "replace GC allocations with locals", createHeap2LocalPass); | |||
| registerPass("heap-snapshot-analysis", | |||
| "Ingest a Chrome DevTools heap snapshot and analysize the " | |||
There was a problem hiding this comment.
Suggested change
| "Ingest a Chrome DevTools heap snapshot and analysize the " | |
| "ingest a Chrome DevTools heap snapshot and analyze the " |
| @@ -426,6 +437,16 @@ struct Value { | |||
| return obj->count(x) > 0; | |||
| } | |||
|
|
|||
| Ref maybeGet(IString x) { | |||
There was a problem hiding this comment.
Is this doing JS-like property access on an object? Please add a comment. And, should the if below be an assert perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome and Edge DevTools can capture heap snapshots, which are JSON
representations of the entire object graph at a moment in time. Add a
pass that can parse such a snapshot and report statistics about how much
of the heap is occupied by Wasm objects and what the top types are by
cumulative heap size and allocation count.