Skip to content

🐛 Fixed if all comments are hidden, no comments are visible #22912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🐛 Fixed if all comments are hidden, no comments are visible #22912

wants to merge 2 commits into from

Conversation

djskinner
Copy link

closes #22331

load the auth frame even if there are no visible comments because we can't check for hidden comments without having the auth frame loaded

The fix is based on the suggestion in #22331 (comment)

Change covered with automated tests and confirmed manually in dev environment.

🐛 Fixed if all comments are hidden, no comments are visible
c3d052c 
closes TryGhost#22331

load the auth frame even if there are no visible comments because we can't check for hidden comments without having the auth frame loaded
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 16, 2025 •
edited
Loading

Walkthrough

The changes update the conditional logic for rendering the <AuthFrame> component in the application's main file. Previously, <AuthFrame> was displayed only if there was at least one comment present. After the update, it is rendered whenever the application's initialization status is 'success', regardless of the number of comments. Correspondingly, the end-to-end test suite for admin moderation was revised: two tests that checked for the presence or absence of the auth iframe based on comment count were replaced by a single test that verifies the auth iframe is rendered. Additionally, a new test was introduced to confirm that the comment panel appears even when all comments have a status of "hidden." No changes were made to the declarations of exported or public entities in the application code.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/comments-ui/src/App.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-i18next".

(The package "eslint-plugin-i18next" was not found when loaded as a Node module from the directory "/apps/comments-ui".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-i18next@latest --save-dev

The plugin "eslint-plugin-i18next" was referenced from the config file in "apps/comments-ui/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3d052c and c8b91c1.

📒 Files selected for processing (1)
  • apps/comments-ui/src/App.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/comments-ui/src/App.tsx
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

djskinner
djskinner commented Apr 16, 2025
View reviewed changes
apps/comments-ui/src/App.tsx Outdated
@@ -224,7 +224,7 @@ const App: React.FC<AppProps> = ({scriptTag}) => {
<CommentsFrame ref={iframeRef}>
<ContentBox done={done} />
</CommentsFrame>
{state.comments.length > 0 ? <AuthFrame adminUrl={options.adminUrl} onLoad={initAdminAuth}/> : null}
{state.initStatus === 'success' && <AuthFrame adminUrl={options.adminUrl} onLoad={initAdminAuth}/>}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first tried always rendering <AuthFrame but that lead to a stuck loading state. Perhaps a more involved change is required to avoid this conditional render entirely.

kaueburiti
kaueburiti reviewed Apr 16, 2025
View reviewed changes
apps/comments-ui/src/App.tsx Outdated
@@ -224,7 +224,7 @@ const App: React.FC<AppProps> = ({scriptTag}) => {
<CommentsFrame ref={iframeRef}>
<ContentBox done={done} />
</CommentsFrame>
{state.comments.length > 0 ? <AuthFrame adminUrl={options.adminUrl} onLoad={initAdminAuth}/> : null}
{state.initStatus === 'success' && <AuthFrame adminUrl={options.adminUrl} onLoad={initAdminAuth}/>}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could reuse the done constant to avoid logic duplication, what do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the suggestion, I've made that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaueburiti kaueburiti kaueburiti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

if all comments are hidden, no comments (not even hidden ones) are visible
2 participants
@djskinner @kaueburiti