Removed site.changed event for AP

[vershwal]

Ref https://linear.app/ghost/issue/AP-1063/

[coderabbitai]

Walkthrough

The change updates the getExpectedWebhooks method in the ActivityPubService class by removing the webhook configuration for the 'site.changed' event. After this modification, the method now returns only the webhook configuration for the 'post.published' event. No other parts of the method or class are altered, and the method signature remains the same. The update solely affects the contents of the returned array of expected webhooks, reducing it by one entry. Correspondingly, the unit tests in ActivityPubService.test.ts were updated to expect one webhook instead of two when validating the initialiseWebhooks method. No other logic or structural changes were introduced in this update.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6cb73e and b842806.

📒 Files selected for processing (1)

• ghost/core/test/unit/server/services/activitypub/ActivityPubService.test.ts (3 hunks)

🔇 Additional comments (3)

ghost/core/test/unit/server/services/activitypub/ActivityPubService.test.ts (3)

111-111: Webhook count correctly updated to 1

This change correctly updates the expected webhook count from 2 to 1, reflecting the removal of the site.changed event webhook in the ActivityPubService as specified in the PR objective.

---

157-157: Webhook count correctly updated to 1

This change correctly updates the expected webhook count from 2 to 1 in the second test case, maintaining consistency with the implementation change that removed the site.changed event webhook.

---

216-216: Webhook count correctly updated to 1

This change correctly updates the expected webhook count from 2 to 1 in the third test case, ensuring consistent testing behavior with the implementation change that removed the site.changed event webhook.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.