RuntimeErrorCatcher + Runtime Elements #7823
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
requested review from
APickledWalrus
and removed request for
a team
sovdeeth
requested changes
Apr 23, 2025
src/main/java/ch/njol/skript/test/runner/ExprRuntimeErrors.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorManager.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Apr 24, 2025
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorCatcher.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorCatcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorCatcher.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorCatcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorCatcher.java
Show resolved
Hide resolved
Absolutionism
changed the title
sovdeeth
requested changes
Apr 24, 2025
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorCatcher.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a
RuntimeErrorCatcherallowingRuntimeErrorsprinted fromRuntimeErrorManagerto be caught and logged.With this addition, allows for a
SecCatchErrorsandExprCaughtErrorsto create code that catches errors, preventing them from being logged into terminal, and accessing the errors that were caught.In the related issue (by me), I realized that
SecParsenever ran the code within the section, so I decided to make a new section and expression that waySecParsecould maintain it's behavior.Target Minecraft Versions: any
Requirements: none
Related Issues: #7766