Improve API for tracking delayed execution at runtime. #7777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current method of checking if the current execution has been delayed utilises Delay.isDelayed(Event), which returns whether a delay has been run in that event before. If the event only corresponds to a single trigger, this is ok. However, as soon as 2 triggers enter the picture, problems arise:
This PR attempts to resolve that by moving this logic to Trigger, so each trigger tracks whether it has been delayed for an Event or not. The old methods are deprecated and marked for removal, but are still functional.
Current issues/concerns:
Some simple cleanup was done to classes affected by the deprecation. Anything more is out of scope.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7393 (not a fix)