-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add tox for Python testing #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
HI @cgoldberg , Would it be helpful to add this information to the Selenium documentation page at https://www.selenium.dev/documentation/webdriver/getting_started/using_selenium/? Thanks, |
I just had a look at it and there is some outdated information for running the Python tests. It refers to using
|
I just viewed that page again, and it actually doesn't make sense to add any more info there. The change in this PR is only relevant for running the Python example tests in this repo, not selenium in general. A more relevant place for this information would be in |
@harsha509 ok.. README is updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, makes sense.
LGTM!
Thank you @cgoldberg !
User description
Description
This PR adds a minimal tox configuration (
tox.ini
) for running the Python example tests across multiple Python versions. (see: https://tox.wiki)You can run the tests against all Python versions
3.9-3.13
by runningtox
, or you can run against a specific environment:tox -e py313
I didn't change CI to use this because, we are already testing against all supported Python versions in the workflow.
Motivation and Context
This is just a convenience for running local tests and can be used in the future when we add linting.
Types of changes
Checklist
PR Type
Tests, Enhancement
Description
Add
tox.ini
for multi-version Python test automationUpdate
requirements.txt
to includetox
dependencyEnable local testing across Python 3.9-3.13 with tox
Changes walkthrough 📝
tox.ini
Add tox.ini for Python multi-version test automation
examples/python/tox.ini
tox.ini
configuration filerequirements.txt
Add tox to Python requirements for local testing
examples/python/requirements.txt
tox==4.25.0
to requirements