fix(ui5-side-navigation): add parent item to submenu #11379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the interaction design clicking on the parent item in the Overflow menu should only open the sub-menu, but should not select the parent item. Clicking on the parent item in the sub-menu selects it and closes the menu - this is the only way to select the parent item in the overflow menu (the menu lacks two-click area functionality for the moment). This is the reason why we add again the parent item also in the sub-menu. JIRA: BGSOFUIRODOPI-3443
…SideNavOverflowRepertParent
dimovpetar
requested changes
Apr 28, 2025
| @@ -58,6 +58,10 @@ | |||
| height: 0.875rem; | |||
| } | |||
|
|
|||
| :host(.ui5-navigation-menu-item-root-parent)::part(content) { | |||
| font-weight: bold; | |||
There was a problem hiding this comment.
Why add font-weight? It is not mentioned in the VD
| @@ -27,18 +27,34 @@ export default function SideNavigationTemplate(this: SideNavigation) { | |||
| tooltip={item._tooltip} | |||
| ref={this.captureRef.bind(item)} | |||
| > | |||
| {(item.children.length && !item.unselectable) ? | |||
There was a problem hiding this comment.
Better use item.items.length
| @@ -27,18 +27,34 @@ export default function SideNavigationTemplate(this: SideNavigation) { | |||
| tooltip={item._tooltip} | |||
| ref={this.captureRef.bind(item)} | |||
| > | |||
| {(item.children.length && !item.unselectable) ? | |||
There was a problem hiding this comment.
Better replace ternary operator with &&
item.items.length > 0 && !item.unselectable && <NavigationMenuItem ...> ... </NavigationMenuItem>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the interaction design clicking on the parent item in the Overflow menu should only open the sub-menu, but should not select the parent item.
Clicking on the parent item in the sub-menu selects it and closes the menu - this is the only way to select the parent item in the overflow menu (the menu lacks two-click area functionality for the moment).
This is the reason why we add again the parent item also in the sub-menu.
JIRA: BGSOFUIRODOPI-3443