Reworked Audio Engine to use SoLoud
instead of irrKlang
#452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces irrKlang by SoLoud.
The objective of this change is to get rid of
irrKlang
, which isn't very permissive:The sound system has been implement to keep the same settings/params as the
irrKlang
implementation. No regression has been found (yet). One notable advantage of this implementation (usingSoLoud
) is thatSound
resources can now pre-load the audio, instead of loading it on the fly, which could potentially hurt performance.Review Guidance
Tested without an active audio device, and it works!
To-Do
SoLoud::Wav
) to avoid using raw pointers/allocsset3dSourceMinMaxDistance
to get the same output as irrKlang (will be exposed later)Hide the backend a little bit moreI think it's pretty good as-isRelated Issues
Fixes #451