-
Notifications
You must be signed in to change notification settings - Fork 288
Add shadow effect to libopenshot
#999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aperture147
wants to merge
23
commits into
OpenShot:develop
Choose a base branch
from
aperture147:shadow-effect
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+470
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss for better encapsulation
… for alpha support
…nstructor documentation
…ries and improve code clarity
… Shadow effect JSON output
…operties from float to int for consistency
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #999 +/- ##
===========================================
- Coverage 54.89% 54.59% -0.30%
===========================================
Files 185 187 +2
Lines 16800 16905 +105
===========================================
+ Hits 9222 9229 +7
- Misses 7578 7676 +98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi, this PR is related to #998. Please check it out first. I also included test cases for that pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are no drop shadow effect implemented in
libopenshot
. To achieve that, people usually do this trick:This approach has two disadvantages:
My implementation of Shadow effect could solves those disadvantages by two features:
Please check this out! All contributions are appreciated!