Updated dependencies and added tests #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanaelA
suggested changes
Oct 1, 2020
There was a problem hiding this comment.
Hey, can you either reset the PR to use all these these JAR's/LIB'S that already exist in libs/
https://github.com/NativeScript/android-dts-generator/tree/master/libs/androidx/1.0.0
OR move them from libs/ to this location (and make sure whatever points to libs is updated). But we probably don't want TWO copies of most these in git...
|
sure, I can do this, but then if they are changed, the expected result should also be replaced |
vtrifonov
force-pushed
the
trifonov/update-and-tests
branch
from
d10631d to
45001ef
Compare
|
Done! Added also a note in the readme |
NathanaelA
approved these changes
Oct 16, 2020
This comment was marked as abuse.
This comment was marked as abuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Add tests #25