Skip to content

New launch kernel for python #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 141 commits into from
Apr 3, 2025
Merged

New launch kernel for python #2706

merged 141 commits into from
Apr 3, 2025

Conversation

annagrin
Copy link
Collaborator

@annagrin annagrin commented Mar 6, 2025 •
edited
Loading

Description

Use new launch kernel from Python code for quantum devices.

This enables new synthesis (including state synthesis) for quantum devices in Python.

Required: #2644
Requires: #2291

Closes: #2299
Towards: #1931

bmhowe23 and others added 30 commits October 17, 2024 14:33
@bmhowe23 @annagrin
DCO Remediation Commit for Ben Howe <bhowe@nvidia.com>
ac01dd1 
I, Ben Howe <bhowe@nvidia.com>, hereby add my Signed-off-by to this commit: 86681ef

Signed-off-by: Ben Howe <bhowe@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
State pointer synthesis for quantum hardware
21a87c1 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge with main
3fc56de 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge with main
7969a75 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Fix test failure on anyon platform
755d0d1 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…
dc5e77e 
…antum-device-state
@annagrin
Make StateInitialization a funcOp pass
382bc99 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Fix issues and tests for the rest of quantum architectures
d3a05d4 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge with main
ac151f2 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Fix failing quantinuum state prep tests
51ef054 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…
0cdf3e9 
…antum-device-state
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…
5307aa4 
…antum-device-state
@annagrin
Address CR comments
a7f5387 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge with main
eb8db13 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Format
9f0937f 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Fix failing test
2f3a623 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Format
b381350 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Format
dc87ca4 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…
e4c7735 
…antum-device-state
@annagrin
Replaced getState intrinsic by cc.get_state op
53a34c9 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…
30777f3 
…antum-device-state
@annagrin
Remove print
fe6d409 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Remove getCudaqState references
48704e3 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Minor updates
137f621 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Fix failing quake test
ad7c6bc 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…
83683f7 
…antum-device-state

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Add a few state-related cc ops
78c0a44 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…
6682c39 
…ate-ops

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Fix test_argument_conversion
102f819 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…
6b2c015 
…ate-ops

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
github-actions bot pushed a commit that referenced this pull request Mar 31, 2025
@cuda-quantum-bot
Docs preview for PR #2706.
ed139a2
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 1, 2025
@cuda-quantum-bot
Docs preview for PR #2706.
4a80e11
schweitzpgi
schweitzpgi approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Anna.

annagrin added 3 commits April 2, 2025 11:17
@annagrin
Address CR comments
5a506e8 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…
f99e3c4 
…ate-synthesis-python

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'state-synthesis-python' of https://github.com/annagrin/…
e3f45f5 
…cuda-quantum into state-synthesis-python

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 2, 2025
@cuda-quantum-bot
Docs preview for PR #2706.
481946b
annagrin added 4 commits April 2, 2025 14:21
@annagrin
Address CR comments
e2784a2 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Address CR comments
1171b34 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…
30469ff 
…ate-synthesis-python

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Remote unrelated changes
5a47157 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin annagrin mentioned this pull request Apr 3, 2025
Open
@annagrin annagrin enabled auto-merge (squash) April 3, 2025 00:59
@annagrin annagrin disabled auto-merge April 3, 2025 01:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
@cuda-quantum-bot
Docs preview for PR #2706.
802220a
@annagrin annagrin enabled auto-merge (squash) April 3, 2025 16:31
annagrin added 4 commits April 3, 2025 09:47
@annagrin
fix failing tests
2dd1ec6
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…
1cf54d6 
…ate-synthesis-python

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
DCO Remediation Commit for Anna Gringauze <agringauze@nvidia.com>
4bc229e 
I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: 2dd1ec6

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Remove debugging code
8ace3be 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin annagrin merged commit a0f6ac4 into NVIDIA:main Apr 3, 2025
195 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2706.
d5de3db
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amccaskey amccaskey amccaskey left review comments

@boschmitt boschmitt boschmitt left review comments

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New launch kernel is not invoked for python
5 participants
@annagrin @amccaskey @boschmitt @schweitzpgi @bmhowe23