Player Collector Badge #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When player sits using ".siton" or "Alt + E" on someone's head, iterates through players and upgrades badge for every participant in player tower.
|
There has to be a better way that doesn't requiring iterating over every player everytime. I also feel like there should be a way to make the badge silent and not post in chat but I don't know for sure (not just because I'm not in the GitLab org anymore, but because MetaWorks has always been a gatekept repo) |
Zeni44
requested changes
Mar 23, 2025
Replace iterator with recursive lookup to find root player Make badge upgrade silent Replace %mod format with basic string concat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When player sits using ".siton" or "Alt + E" on someone's head, iterates through players and upgrades badge for every participant in player tower.