Skip to content

wandb logger args #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ysjprojects
Copy link
Contributor

@ysjprojects ysjprojects commented Mar 18, 2025

Addresses #1909.

More fine-grained logging args: supports wandb args specifying run_name and group_name for now.

@dataclass
class LogArgs:
    """Logging-related arguments"""

    wandb_project: Optional[str] = None
    """Wandb project name"""
    wandb_run: Optional[str] = None
    """Wandb run name"""
    wandb_group: Optional[str] = None
    """Wandb group name"""

New LoggerArgs as it fits neither TrainArgs nor EvalArgs. We can expand on this in the future.

@Borda
Copy link
Member

Borda commented Apr 15, 2025

wandb is not the only one or default logger so we shall not name it with generic LogArgs

@Borda Borda marked this pull request as draft April 15, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants