Skip to content

Update documentation of coq.elpi.accumulate #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tragicus
Copy link
Contributor

Documentation related to #803.

Copy link
Contributor

@gares gares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I tried to make the wording less ambiguous (the end of a program is also the bottom of it, where clauses are added).

I think one comment is wrong, do you agree?

begin/end-module)
- library is the current file (the module that is named after the file)
begin/end-module), the clauses will be accumulated at the end of the program
or the start of another program (whichever comes first)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
or the start of another program (whichever comes first)

I'm not sure this is the case, did you test it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I seem to observe when I accumulate the coercion and it is used in the subsequent elaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants