Replace litConnectModal with Wagmi #751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansonhkg
requested changes
Dec 31, 2024
There was a problem hiding this comment.
- Removing part of the existing code makes it a breaking change. Could you please revert the changes, set them as default, add a deprecation message, and allow users to opt for WAGMI if they choose to? This way, we can release this as a minor update.
- Could we also figure out why it’s failing on the CI?
Publish version 7.0.4
- Add clear description of logger package's purpose and functionality - Improve WASM package description and formatting - Enhance nacl package description with its role in the ecosystem - Clarify lit-node-client-nodejs package purpose and benefits Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
…ples Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
- Add comprehensive package descriptions - Standardize README structure across packages - Add installation and quick start sections - Include key features and core functionality - Fix formatting issues from linter - Update root README with core systems overview Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
- Remove outdated sections (react demo, package deletion, graph dependencies) - Enhance documentation structure and readability - Improve section headings and descriptions - Add detailed tables for environment variables - Restructure error handling and troubleshooting guides Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
Co-authored-by: Federico Amura <federicoamura@gmail.com> Signed-off-by: Anson <ansonox@gmail.com>
Co-Authored-By: anson@litprotocol.com <anson@litprotocol.com>
CI is failing because the PR is from a fork. CI runs in @anshss environment instead of Lit and it cannot setup shiva (gh security) |
| ) => { | ||
| const chain = Object.values(LIT_CHAINS).find((c) => c.chainId === chainId); | ||
| if (!chain) { | ||
| throw new Error(`Chain ID ${chainId} not supported`); |
There was a problem hiding this comment.
Can we throw a ParamsMissingError or another LitError? 🙏🏻
Same on all other throw Error lines
| * | ||
| * @return { Promise<ConnectWeb3Result> } web3, account | ||
| */ | ||
| export const connectWeb3 = async ({ | ||
| export const connectWeb3WithLitConnectModal = async ({ |
There was a problem hiding this comment.
Let's re-export this function as connectWeb3 too and mark both (this and the one with the original name) as deprecated to retain backwards compatibility
…s-test-issue760 fix LIT-Protocol#760 wrapped-keys test to expect a single ACC object instead of an array
…ests-issue758 fix LIT-Protocol#758 logger tests
…7-update-readmes docs: improve package descriptions and standardize README formatting
…9-js-sdk-fix-ci-cus-rust-compiler-version-is-outdated fix(ci): update Rust version to 1.83.0 for wasm compatibility
Ansonhkg
changed the base branch from
master
to
feat/naga-fix-bls-wasm-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per this ticket, litConnectModal is now replaced with a more maintained wallet provider wagmi
Wagmi is chosen amongst other providers as most providers are built over wagmi and wagmi provides much more low-level control. It doesn't enforce any UI opinion and it have more granular error-handling capability
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration