Skip to content

Fix activating [sources] with relative paths #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mortenpi
Copy link

So.. a very rough attempt to fix #92. Basically, the idea is to just loop over the source Project.toml and replace the relative paths with absolute paths, before it gets resolved.

Seems to work, but I really don't follow the code well enough to know if it's in the right place. Or even the right solution.

cc @KristofferC, should you have any bandwith to take a look at this.

@oscardssmith
Copy link

I just ran into this as well. It would be great if we could get this in.

@KristofferC
Copy link
Member

@oxinabox
Copy link
Member

If @KristofferC says it is good then that is enough for me.
Do you have merge rights on this repo @KristofferC ?
you should given it is mostly hacked up version of code you wrote

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.00%. Comparing base (b652737) to head (6496f33).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/julia-1.11/activate_set.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #93       +/-   ##
===========================================
+ Coverage   20.66%   50.00%   +29.33%     
===========================================
  Files          27       28        +1     
  Lines         692      716       +24     
===========================================
+ Hits          143      358      +215     
+ Misses        549      358      -191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to activate environments with [sources] with relative paths
4 participants