Skip to content

add support for Sixel #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for Sixel #133

wants to merge 1 commit into from

Conversation

IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Apr 15, 2025

I think this is ok as a direct dep?
Also, needs testing.

If REFERENCETESTS_SIXEL=1

Screenshot 2025-04-15 at 1 04 20 PM

@oxinabox
Copy link
Member

Sixel actually adds a 50 direct dependencies, including ImageCore, which we currently use a hack to avoid depending on directly.
With that said maybe we should just depend on it (and ImageCore and XImageInTerm) directly,
making maintenance and use easier.

If we are depending on it directly, i think we don't need to use a enviroment variable to decide if to use it or not, and can just use Sixel.is_sixel_supported() and if so always use it. Its always better, no?

@IanButterworth
Copy link
Collaborator Author

Unfortunately that returns false inside the Pkg.test worker in a local terminal where it otherwise returns true.

@oxinabox
Copy link
Member

Oh thats annoying we should open an issue on Sixel.jl about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants