CartesianIndex
constructor for BandIndex
#1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows easier conversion from a
BandIndex
to aCartesianIndex
by using theCartesianIndex
constructor. It also skips the intermediate conversion into_indices
where we need the(row, column)
tuple directly.After this, the following is possible:
I had not added the constructor earlier to avoid potential invalidations, but I don't think this is a factor, given that
Base
already defines four methods forCartesianIndex
.