Skip to content

Outsource Cython backend #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 28, 2025
Merged

Outsource Cython backend #376

merged 10 commits into from
Apr 28, 2025

Conversation

MuellerSeb
Copy link
Member

Now that we have GSTools-Cython, we can remove the cython code from GSTools.

@MuellerSeb MuellerSeb marked this pull request as draft February 4, 2025 10:52
@MuellerSeb MuellerSeb added enhancement New feature or request Refactoring Code-Refactoring needed here CI/CD dependencies Pull requests that update a dependency file labels Feb 4, 2025
@MuellerSeb MuellerSeb added this to the 1.7 milestone Feb 4, 2025
@MuellerSeb MuellerSeb self-assigned this Feb 4, 2025
@MuellerSeb MuellerSeb marked this pull request as ready for review February 16, 2025 11:34
@MuellerSeb MuellerSeb requested a review from LSchueler February 16, 2025 23:01
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really cool to see how fast GSTools now "build" with GSTools-Cython already built. Thank you this PR and for the new Cython repo!!

Two things to think about.

  • Now that I read the installation guide again, I think that the part about building Cython with parallel support sounds pretty complicated, which it really isn't. Maybe first provide the code block and then the explanation for those who are really interested?

  • Because the Rust code runs parallel without any extra installation steps when using pip, maybe that installation guide should come before the Cython part in order to keep it as simple as possible for the users? And maybe we should tone the text down a bit. It's probably not going to completely replace the Cython code anytime soon ;-)

But apart from that, I don't see anything to complain about, so LGTM ;-)

@MuellerSeb
Copy link
Member Author

I would keep gstools-core on second place in docs, since there is no conda package for gstools-core. ATM I have no experience with putting a rust package on conda-forge. But I think it's no rocket science.

@MuellerSeb
Copy link
Member Author

LGTM 🎉

@MuellerSeb MuellerSeb merged commit 0a5697b into main Apr 28, 2025
35 checks passed
@MuellerSeb MuellerSeb deleted the outsource_cython branch April 28, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD dependencies Pull requests that update a dependency file enhancement New feature or request Refactoring Code-Refactoring needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants