Skip to content

[ENHANCEMENT] Selecting Random in Freeplay can choose a Random available instrumental #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

VioletSnowLeopard
Copy link

Does this PR close any issues? If so, link them below.

Closes #3570

Briefly describe the issue(s) fixed.

Currently, using the random capsule to choose a song always uses the base instrumental for the song. This PR allows the random capsule to choose a random instrumental from the list of available instrumentals for the song.

Include any relevant screenshots or videos.

Videos of the random option choosing the Pico instrumental for the song:

dadbattle.mp4
philly-nice.mp4

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: medium A medium pull request with 100 or fewer changes. labels Apr 16, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. size: medium A medium pull request with 100 or fewer changes. labels Apr 16, 2025
TechnikTil

This comment was marked as outdated.

Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thing is...
what if people don't want random to change the instrumental?

there should be a way to deny random from changing the instrumental

Copy link
Contributor

@sphis-Sinco sphis-Sinco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have a way of displaying what instrumental was chosen and having an option to change the instrumental? I wouldn't want to play regular Roses with the regular instrumental but then get the Pico variation.

Copy link
Contributor

@sphis-Sinco sphis-Sinco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing my recommendation!
Looking good!

@VioletSnowLeopard
Copy link
Author

When selecting the random capsule, you can now choose if you want the instrumental to be random or default:

choose-random-or-default.mp4

@sphis-Sinco
Copy link
Contributor

thing is... what if people don't want random to change the instrumental?

there should be a way to deny random from changing the instrumental

Heh

@Hundrec
Copy link
Collaborator

Hundrec commented Apr 17, 2025

Okay, this is very cool

Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok im happy now

@amyspark-ng
Copy link
Contributor

oh that's peak
that's peak...

Don't allow letter sort input while the instrumental selector is up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants