Skip to content

[FEATURE/ENHANCEMENT] Set Character Event #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[FEATURE/ENHANCEMENT] Set Character Event #4730

wants to merge 1 commit into from

Conversation

anysad
Copy link
Contributor

@anysad anysad commented Apr 15, 2025 •
edited
Loading

Requires FunkinCrew/funkin.assets#164 for this to work properly!

Briefly describe the issue(s) fixed.

  • This PR aims to add a new song event where you are able to change the desired character mid-song!
  • A new function loadCharacter(charId:String, charType:CharacterType, ?swap:Bool = false) is made to have the ability to easily add the characters and swap them within your mods.
  • Also made some cleaning of the code in initCharacters()

‼️ THIS WILL BREAK MODS THAT USE CharacterType‼️

Include any relevant screenshots or videos.

8mb.video-qds-b48VWRmh.mp4

@github-actions github-actions bot added status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. labels Apr 15, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. topic: breaking change Introduces a change that is not compatible with older versions. Existing code may need revision. labels Apr 15, 2025
@trayfellow
Copy link

trayfellow commented Apr 16, 2025 •
edited
Loading

FINALLYYYYYY I'VE WAITED AGES FOR NATIVE SUPPORT ON THIS

images (2) (22)
images (2) (23)

@anysad
Copy link
Contributor Author

anysad commented Apr 16, 2025

FINALLYYYYYY I'VE WAITED AGES FOR NATIVE SUPPORT ON THIS

lolol hopefully this gets accepted so you can finally be happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: breaking change Introduces a change that is not compatible with older versions. Existing code may need revision. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anysad @trayfellow @AbnormalPoof