fixes max_eval_time_mins and max_eval_time_mins to allow None and inf - also allows steady state estimator to use template search spaces #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[please review the Contribution Guidelines prior to submitting your pull request. go ahead and delete this line if you've already reviewed said guidelines.]
What does this PR do?
As described in this issue: EpistasisLab/tpot2#169
max_eval_time_mins does should work with inf or None, but actually throws an error. This update fixes that issue. I also renamed some variables and moved unit conversions for better clarity. Also updated the doctrings to match the default values. (What the default values should be can be up for discussion as well. Perhaps early_stop should be set by default? I can imagine users running tpot and not realizing it doesn't have a stopping criteria by default other than waiting an hour).
I also updated TPOTEstimatorSteadyState to allow the template search spaces to be used ('linear', 'graph', 'linear-light', etc).
Any background context you want to provide?
What are the relevant issues?
Originally brought up in the TPOT2 repo here:
EpistasisLab/tpot2#169