-
Notifications
You must be signed in to change notification settings - Fork 439
Improved Promise handling for showInterstitial() #506
base: master
Are you sure you want to change the base?
Conversation
…when ad is loaded
Do you think this will break app behavior for current users? What I dislike is this means it's even less aligned with iOS. |
I'm not sure about it. It could break something, when someone wants to do some stuff when the interstitial is loaded. I don't know, because from my point of view it makes more sense to do stuff, when the ad has been closed...
I can fully understand that. My app currently doesn't run on iOS and I have no experience with native iOS development. :( |
Roger that, thanks for the clarifications 👍 Let's keep this open to see if others have an opinion on when the promise should resolve. |
Good idea 👍 |
This PR is nearly 1 year old. Do you think it's still possible to merge? There is also another related open PR: #775 |
Let
firebase.admob.showInterstitial()
fullfil promise when the ad is closed instead of when the ad is loaded.This way we can detect when the ad is closed and perform following actions. Before we only knew the ad was loaded, but we didn't knew if the user closed the ad already.