Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Improved Promise handling for showInterstitial() #506

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

svzi
Copy link
Contributor

@svzi svzi commented Oct 3, 2017

Let firebase.admob.showInterstitial() fullfil promise when the ad is closed instead of when the ad is loaded.

This way we can detect when the ad is closed and perform following actions. Before we only knew the ad was loaded, but we didn't knew if the user closed the ad already.

@EddyVerbruggen
Copy link
Owner

Do you think this will break app behavior for current users?

What I dislike is this means it's even less aligned with iOS.

@svzi
Copy link
Contributor Author

svzi commented Oct 3, 2017

Do you think this will break app behavior for current users?

I'm not sure about it. It could break something, when someone wants to do some stuff when the interstitial is loaded. I don't know, because from my point of view it makes more sense to do stuff, when the ad has been closed...

What I dislike is this means it's even less aligned with iOS.

I can fully understand that. My app currently doesn't run on iOS and I have no experience with native iOS development. :(

@EddyVerbruggen
Copy link
Owner

Roger that, thanks for the clarifications 👍

Let's keep this open to see if others have an opinion on when the promise should resolve.

@svzi
Copy link
Contributor Author

svzi commented Oct 3, 2017

Good idea 👍

@muratcorlu
Copy link

This PR is nearly 1 year old. Do you think it's still possible to merge? There is also another related open PR: #775

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants