Explicitly create /nix folder on installation
#1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey everyone, while using this installer, when using the uninstaller it won't delete the `/nix` folder. This is a nuisance on e.g. Fedora Atomic images, where you'd have to go through extra steps to delete `/`. Checking that the installer will only revert the items it did while installing, I think that explicitly adding `/nix` to `PATHS` would solve the issue. Thanks! Please feel free to close if it's not relevant.
cole-h
reviewed
Apr 21, 2025
| @@ -8,6 +8,7 @@ use crate::action::{ | |||
| }; | |||
|
|
|||
| const PATHS: &[&str] = &[ | |||
| "/nix", | |||
There was a problem hiding this comment.
I don't think we want to do it as part of CreateNixTree, as that happens before we hit the revert for nix.mount, etc in the ostree planner, which will probably cause issues.
We'll probably want to create something similar to RevertCleanSteamosNixOffload for the ostree planner that does nothing in execute, but deletes /nix in revert, and have it be one of the first steps in the plan (so it's one of the last steps to be reverted upon uninstall).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey everyone,
while using this installer, when using the uninstaller it won't delete the
/nixfolder. This is a nuisance on e.g. Fedora Atomic images, where you'd have to go through extra steps to delete/. Checking that the installer will only revert the items it did while installing, I think that explicitly adding/nixtoPATHSwould solve the issue. Thanks! Please feel free to close if it's not relevant.Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems: