Skip to content

chore: remove obsolete version field in docker-compose.yml #13246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

smola
Copy link
Member

@smola smola commented Apr 21, 2025

Avoid warnings:

❯ scripts/ddtest 
WARN[0000] /home/smola/dd/dd-trace-py/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
[+] Pulling 1/1
 ✔ testrunner Pulled                                                                                                    70.3s 
WARN[0000] /home/smola/dd/dd-trace-py/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
[+] Creating 1/1
[...]

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@smola smola added changelog/no-changelog A changelog entry is not required for this PR. testing labels Apr 21, 2025
@smola smola requested a review from a team as a code owner April 21, 2025 15:27
@smola smola requested a review from emmettbutler April 21, 2025 15:27
Copy link
Contributor

CODEOWNERS have been resolved as:

docker-compose.yml                                                      @DataDog/apm-core-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 236 ± 3 ms.

The average import time from base is: 241 ± 4 ms.

The import time difference between this PR and base is: -4.8 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.187 ms (0.93%)
ddtrace.bootstrap.sitecustomize 1.505 ms (0.64%)
ddtrace.bootstrap.preload 1.505 ms (0.64%)
ddtrace.internal.products 1.505 ms (0.64%)
ddtrace.internal.remoteconfig.client 0.690 ms (0.29%)
ddtrace 0.682 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 21, 2025

Benchmarks

Benchmark execution time: 2025-04-21 16:16:47

Comparing candidate commit 78a7dc7 in PR branch smola/docker-compose-warning with baseline commit 550ecdf in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 497 metrics, 8 unstable metrics.

scenario:iast_aspects-ljust_aspect

  • 🟥 execution_time [+1.082µs; +1.320µs] or [+8.326%; +10.154%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+353.426ns; +393.937ns] or [+11.951%; +13.321%]

scenario:telemetryaddmetric-flush-1-metric

  • 🟥 execution_time [+319.687ns; +461.568ns] or [+7.505%; +10.835%]

@smola smola enabled auto-merge (squash) April 22, 2025 07:46
@smola smola merged commit 04d0b0e into main Apr 22, 2025
765 of 767 checks passed
@smola smola deleted the smola/docker-compose-warning branch April 22, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants