-
Notifications
You must be signed in to change notification settings - Fork 430
docs: upgrade pip command to install build system dependencies #13244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 229 ± 2 ms. The average import time from base is: 232 ± 1 ms. The import time difference between this PR and base is: -2.56 ± 0.07 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-21 18:35:11 Comparing candidate commit b2d78ce in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 500 metrics, 7 unstable metrics. scenario:iast_aspects-replace_aspect
|
@@ -47,7 +47,7 @@ To install all dependencies in one step, use: | |||
|
|||
.. code-block:: bash | |||
|
|||
pip install . --no-build-isolation --no-install | |||
pip install 'setuptools_scm[toml]>=4' 'cython' 'cmake>=3.24.2,<3.28' 'setuptools-rust<2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be simplified with pip install '.[build-system]'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmettbutler The command appears to work but I see the following warning:
WARNING: ddtrace 3.6.0.dev16+gb2d78cefb does not provide the extra 'build-system'
Also the point of the command seemed to be installed deps without building the project, but that actually builds it.
Upgrade pip command to install build system dependencies. Option
--no-install
is not a valid option since pip 7 (release notes).Checklist
Reviewer Checklist